Skip to content

[Security Solutions] Removes deprecation and more copied code between security solutions and lists plugin#100150

Merged
FrankHassanabad merged 2 commits intoelastic:masterfrom
FrankHassanabad:remove-deprecations
May 14, 2021
Merged

[Security Solutions] Removes deprecation and more copied code between security solutions and lists plugin#100150
FrankHassanabad merged 2 commits intoelastic:masterfrom
FrankHassanabad:remove-deprecations

Conversation

@FrankHassanabad
Copy link
Copy Markdown
Contributor

@FrankHassanabad FrankHassanabad commented May 14, 2021 •
edited
Loading

Summary

  • Removes deprecations
  • Removes duplicated code

Checklist

@FrankHassanabad FrankHassanabad self-assigned this May 14, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 14, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 198 195 -3
securitySolution 2046 2112 +66
total +63

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lists 241 210 -31

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 68.4KB 55.2KB -13.1KB
securitySolution 6.7MB 6.7MB +30.4KB
total +17.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
lists 60 58 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lists 175.3KB 190.1KB +14.8KB
securitySolution 161.3KB 159.7KB -1.7KB
total +13.1KB
Unknown metric groups

API count

id before after diff
lists 263 232 -31

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@FrankHassanabad FrankHassanabad marked this pull request as ready for review May 14, 2021 22:06
@FrankHassanabad FrankHassanabad requested review from a team as code owners May 14, 2021 22:06
@FrankHassanabad FrankHassanabad added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 14, 2021
spong
spong approved these changes May 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks for zooming with me over these changes and cleaning up more duplication. Nice find on the missing bug fix between the dupes as well! 🙂

@FrankHassanabad FrankHassanabad changed the title Removes deprecation and more copied code. [Security Solutions] Removes deprecation and more copied code between security solutions and lists plugin May 14, 2021
@FrankHassanabad FrankHassanabad merged commit bfe08d2 into elastic:master May 14, 2021
@FrankHassanabad FrankHassanabad deleted the remove-deprecations branch May 14, 2021 22:56
FrankHassanabad
FrankHassanabad commented May 14, 2021
View reviewed changes
Comment thread x-pack/plugins/lists/public/exceptions/components/builder/helpers.ts
} else if (createExceptionListItemSchema.is(item)) {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { meta: _, ...rest } = item;
const { meta, ...rest } = item;
Copy link
Copy Markdown
Contributor Author

@FrankHassanabad FrankHassanabad May 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: @yctercero , this looked like it was fixed in the copied version so I removed it here. Let me know if that's wrong.

Copy link
Copy Markdown
Contributor

@yctercero yctercero May 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the cleanup!

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 14, 2021
@FrankHassanabad @kibanamachine
[Security Solutions] Removes deprecation and more copied code between…
9828ff2 
… security solutions and lists plugin (elastic#100150)

## Summary

* Removes deprecations 
* Removes duplicated code

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@kibanamachine kibanamachine mentioned this pull request May 14, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 14, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 15, 2021
@kibanamachine @FrankHassanabad
[Security Solutions] Removes deprecation and more copied code between…
a37a0c1 
… security solutions and lists plugin (#100150) (#100180)

## Summary

* Removes deprecations 
* Removes duplicated code

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@FrankHassanabad @yctercero
[Security Solutions] Removes deprecation and more copied code between…
a818f14 
… security solutions and lists plugin (elastic#100150)

## Summary

* Removes deprecations 
* Removes duplicated code

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yctercero yctercero yctercero left review comments

@spong spong spong approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FrankHassanabad @kibanamachine @spong @yctercero